Skip to content

Bumped bufr version to 12.0.1 #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
climbfuji merged 6 commits into from
Oct 2, 2023
Merged

Bumped bufr version to 12.0.1 #797

climbfuji merged 6 commits into from
Oct 2, 2023

Conversation

@srherbener
Copy link
Collaborator

@srherbener srherbener commented Sep 29, 2023 •
edited by climbfuji
Loading

Summary

This PR bumps the bufr version in common package.py to version 12.0.1.

Testing

I tested building on my Mac and was able to successfully build bufr@12.0.1.

Applications affected

This affects JEDI ioda converters, and other applications that use the NCEPLIBS-bufr package.

Systems affected

List all systems intentionally or unintentionally affected by this PR.

Dependencies

Issue(s) addressed

This partially addresses #778

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@srherbener srherbener mentioned this pull request Sep 29, 2023
Closed
climbfuji
climbfuji previously requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bufr@12.0.1 is not in the release/1.5.1 spack submodule, and also not in jcsda_emc_spack_stack

@climbfuji
Copy link
Collaborator

climbfuji commented Sep 29, 2023

bufr@12.0.1 is not in the release/1.5.1 spack submodule, and also not in jcsda_emc_spack_stack

Dang, my mistake, just saw your spack PR. I'll dismiss my review and look more carefully again. CI is failing, though.

@climbfuji climbfuji dismissed their stale review September 29, 2023 19:04

stupidity

@srherbener
Copy link
Collaborator Author

srherbener commented Sep 29, 2023

I'm getting these error messages for the ubuntu-ci-x86_64-build test:

==> Installing bufr-12.0.1-n2tv7iwsukza4qaehstd3r3keo6dspx5
==> No binary for bufr-12.0.1-n2tv7iwsukza4qaehstd3r3keo6dspx5 found: installing from source
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
1 out of 1 hunk ignored -- saving rejects to file python/CMakeLists.txt.rej
==> Fetching file:///home/ubuntu/spack-stack/source-cache/_source-cache/archive/52/525f26238dba6511a453fc71cecc05f59e4800a603de2abbbbfb8cbb5adf5708.tar.gz
==> Patch /home/ubuntu/spack-stack/CI/actions-runner/_work/spack-stack/spack-stack/spack/var/spack/repos/builtin/packages/bufr/python-version.patch failed.
==> Error: ProcessError: Command exited with status 1:
    '/usr/bin/patch' '-s' '-p' '1' '-i' '/home/ubuntu/spack-stack/CI/actions-runner/_work/spack-stack/spack-stack/spack/var/spack/repos/builtin/packages/bufr/python-version.patch' '-d' '.'

I'm not sure what the problem is. I ran into this with manually building on my Mac, but in that case the prompt I got was:

Reversed (or previously applied) patch detected!  Assume -R? [y]'

(ie, the default response is yes instead of no) and by responding with a return the build took off and completed successfully.

I must be missing something in my feature/burf-12.0.1 branches, but I'm not sure what to change. Any ideas?

Thanks!

@climbfuji
Copy link
Collaborator

climbfuji commented Sep 29, 2023

Looks like one of the patches that spack applies can't be applied cleanly. Maybe it's been fixed in the source code.

@srherbener
Copy link
Collaborator Author

srherbener commented Sep 30, 2023

Looks like one of the patches that spack applies can't be applied cleanly. Maybe it's been fixed in the source code.

Thanks @climbfuji! I think I've got it fixed. The python patch is no longer needed for bufr@12.0.1, so I updated the bufr package.py accordingly.

@climbfuji
Copy link
Collaborator

climbfuji commented Oct 2, 2023

@srherbener I merged JCSDA/spack#330, please update your github submodule pointer and also updated this branch from develop. Thanks!

@srherbener
Copy link
Collaborator Author

srherbener commented Oct 2, 2023

@srherbener I merged JCSDA/spack#330, please update your github submodule pointer and also updated this branch from develop. Thanks!

Done! I also reverted the .gitmodules back to point to the jcsda_emc_spack_stack branch in our spack fork.

@climbfuji climbfuji merged commit d878b33 into JCSDA:develop Oct 2, 2023
climbfuji pushed a commit to climbfuji/spack-stack that referenced this pull request Oct 2, 2023
@srherbener @climbfuji
Bumped bufr version to 12.0.1 (JCSDA#797)
aa870f4 
* Bumped bufr version to 12.0.1, change .gitconfig urls for testing
* Updated spack submodule commit hash
@climbfuji climbfuji mentioned this pull request Oct 2, 2023
Merged
5 tasks
climbfuji added a commit that referenced this pull request Oct 3, 2023
@climbfuji
Merge pull request #803 from climbfuji/feature/bufr-12.0.01-rel151
8dee0b5 
release/1.5.1: bump bufr version to 12.0.1 (cherry-pick #797 from develop)
climbfuji added a commit that referenced this pull request Nov 9, 2023
@climbfuji @ncrossette
@AlexanderRichert-NOAA @srherbener @DavidHuber-NOAA
Merge pull request #866 from climbfuji/feature/merge_rel151_into_dev
d75a997 
* Clarifying directions in Generating new site configs (#791)
* Change prod-util module to prod_util (#794) (#798)
* Bumped bufr version to 12.0.1 (#797)
* Workaround for spack-stack-1.5.0 on Hera: use new noavx512 install, add target 'haswell'
* Update default atlas version to 0.35.0
* Update build variants for ecmwf-atlas
* Update variants for ectrans
* Remove deprecated variant cgal from ecmwf-atlas, since it conflicts with the replacement qhull for tesselation and since it leads to compilation errors in ecmwf-atlas with Intel
* release/1.5.1: fix Intel container build (ectrans error), update Derecho documentation Bugfix/container ectrans fftw derecho docs (#821)
* Comment out intel-oneapi-mkl in configs/containers/docker-ubuntu-intel-impi.yaml and fix wrong variant ~fftw for jedi-base-env in configs/containers/README.md
* Fix incorrect variant name for mkl for package ectrans in configs/common/packages.yaml
* Fix outdated instructions for Derecho in doc/source/PreConfiguredSites.rst
* Update gsi-ncdiag version number in config.
* Update fms default to 2023.02.01
* ESMF@8.5.0, MAPL@2.40.3 as defaults (#839)
* update fms versions in unified-dev
* update fms versions in ufs wm metapackage
* update gftl-shared default to 1.6.1
* release/1.5.1: backport mpich4 workarounds for mapl@2.35.2 and mapl@2.40.3 (#842)
* release/1.5.1: update site config for Hercules (gnu+mvapich2) (#849)
* release/1.5.1: Update site configs for Derecho, Narwhal, Gaea C5, Discover, AWS ParallelCluster, S4 (#853)
* release/1.5.1: add fms@2023.03, site config updates round 3 (#855)
    * Update site configs for NOAA Parallel Works
    * Update casper site config and build documentation
    * Update container specs in configs/containers/README.md
    * Update Hercules site config (gnu@12, mvapich2@2.3.7)
    * Update  doc/source/PreConfiguredSites.rst for casper, hera, gaea-c4, jet
    * Add fms@2023.03 in spack submodule, add to unified-dev and skylab-dev templates
    * Update configs/containers after tagging spack submodule as spack-stack-1.5.1
    * Update documentation for AWS AMI release 1.5.1
    * Update macOS section in doc/source/NewSiteConfigs.rst to match Linux section

---------

Co-authored-by: Nate Crossette <ncrossette@ucar.edu>
Co-authored-by: Alex Richert <82525672+AlexanderRichert-NOAA@users.noreply.github.com>
Co-authored-by: Stephen Herbener <32968781+srherbener@users.noreply.github.com>
Co-authored-by: DavidHuber <David.Huber@noaa.gov>
Co-authored-by: Alex Richert <alexander.richert@noaa.gov>
@srherbener srherbener deleted the feature/bufr-12.0.1 branch December 6, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

@ulmononian ulmononian ulmononian approved these changes

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srherbener @climbfuji @ulmononian @AlexanderRichert-NOAA