Add TLMToolbox executable and test for SOCA #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xian22
requested review from
guillaumevernieres,
kbhargava,
shlyaeva and
tom-j-h
Collaborator
|
Thank you so much for doing this @xian22 ! Similar to the comments in the fv3-jedi PR, can we perhaps replace the current linearizationerror test with this one, and remove the linearizationerror application? I am happy to work on that too if you're busy with other things, let me know! |
Contributor
Author
|
Sort of forgot about this over the holiday, I have removed the old linearization error test and it is replaced with the tool box equivalent. |
Dooruk
approved these changes
Jan 2, 2026
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the an executable for
TLMToolboxas well as a ctest to replace the currentLinearizationErrortest as the executable for that will be removed soon. The new test passes with the reference of the old test which is expected.Issue(s) addressed
Testing
How were these changes tested?
The output using the new app should pass with the existing
LinearizationErrorreference file and it does.What compilers / HPCs was it tested with?
Tested with GNU spack stack 1.9
Dependencies
none