Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TVirtualNode: Make most members private and add readonly properties instead #823

Closed
joachimmarder opened this issue Aug 26, 2018 · 1 comment
Closed

TVirtualNode: Make most members private and add readonly properties instead #823

joachimmarder opened this issue Aug 26, 2018 · 1 comment
Labels
Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Refactoring Internal code changes that improve architecture
Milestone
V7.1

Comments

@joachimmarder
Copy link
Contributor

There is no need to write to these members, doing so may cause a lot of problems. Making them private and adding equally named readonly properties should avoid too many breaking changes.
@joachimmarder joachimmarder added Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Refactoring Internal code changes that improve architecture labels Aug 26, 2018
@joachimmarder joachimmarder added this to the V7.1 milestone Aug 26, 2018
@obones obones mentioned this issue Nov 2, 2018
Closed
@joachimmarder
Copy link
Contributor Author

Duplicate of #832

@joachimmarder joachimmarder marked this as a duplicate of #832 Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Open for Discussion There are several possibilites to address the issue and anyone is invited for comments. Refactoring Internal code changes that improve architecture
Projects
None yet
Milestone
V7.1
Development

No branches or pull requests
1 participant
@joachimmarder