Fix missing defaults for fx_rain and broken weather zone creation
#1283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightrainandwindadded tofx_rainsince it was missing defaults if it was created without any spawn flags (since the JO weather system doesn't use spawn flags). JO's rain system always has random wind, unlike JA's rain system. Enablingwindis close enough for this purpose.JO code:
https://github.com/grayj/Jedi-Outcast/blob/master/code/game/g_fx.cpp#L276-L287
https://github.com/grayj/Jedi-Outcast/blob/master/code/renderer/tr_worldeffects.cpp#L1986-L2003
Auto generated weather zones were also not being created properly beyond first map load because of bad operation placement, resulting in weather effects clipping through geometry. Currently, if a cache file is found and
mWeatherZonesis empty (not all maps have pre-placed weather zones, for example JO's yavin4) thenmWeatherZoneswill never be filled, and the point data from the cached file is useless. Weather zones should always be generated ifmWeatherZonesis empty (whether or not a cache file is found is irrelevant), as the cache file only contains point data, not weather zones themselves.Fixes #1104