Rend2 SP #1179
Draft
Rend2 SP #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Closed
Theres a define in MP that clashes, so it was renamed in MP. Apply this to vanilla too. Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
q_shared.h defines "int COM_GetCurrentParseLine( void )" q_shared.cpp implemented "int COM_GetCurrentParseLine( int index )" Fixed now, so function can actually be used. Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
Adding mdr structs, one more texture compression algorithm, some zone tags, and SkipBracedSection function Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
Cleaned up alot of noise. Code formating will happen in another commit. All work based on: https://github.com/AntiAnti/OpenJK Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
To match MP
Chose the SP variant of this to get rid of the void pointer in the struct, so potentially less casting.
cg_showtris 1 shouldnt use depth culling. Had overseen this before.
ifdefed sp / mp differences
The saber marks in SP use some additional scaling and there's some missing parts still. Also fixed incorrect ifdeffed if else constructs.
Added working IsShaking Co-Authored-By: AntiAnti <17278566+antianti@users.noreply.github.com>
Because there's a skyportal in this map, it always culled all the ui elements because they aren't sky surfaces.
when G2_PERFORMANCE_ANALYSIS
Compiles, haven't tested it though
You can now load yavin_swamp again.
and remove some #ifdef
except for the ones that need info about the entity time or have the volumetric flag.
Fixed dynamic lights when r_specularMapping and r_normalmapping == 0. Also removed specular calculations when r_specularMapping 0 but r_normalmapping 1.
Also stencil buffer is not needed for refractive surfaces
Added debug group annotations and better shader names for captures with debug software like renderdoc.
Prevents drawing a giant blob shadow beneath players when cg_shadows 4 is set after loading a map without it being active.
Drawing the sky is somewhat special as we need to draw every surface and its stages in order. The tesselator for the sky often creates overlaps and this leads to doulbe and tripple applied stages with our usual sorting. Also, all other surfaces in the same sort as the sky need to be rendered after the sky has been rendered.
Fixes incorrectly displayed models and incorrectly discarded models.
…tDefaultState() call
Disabling and enabling parallax mapping is not latched anymore and happens directly when setting the cvar.
Turns out, it breaks things and I was wrong with my assumption that we can merge all of those surface entities. Fixes #63
Also fixes sun flare rendering
It seems to be completely unused in SP though.
Theres some optimizations for the prepass to merge more surfaces which works fine for opaque shaders and remaps that are also opaque. When changing to transparent shaders those optimization didnt work properly as they didnt know about the remap. Remapping now happens when drawsurfaces are added and not when drawing of the surfaces starts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this is basically a SP port of rend2. This also puts most of the rend2 code to the shared folder. I also started reducing the differences between SP and MP renderer APIs but I think I can do some more, so just a draft for now. This also needs testing.
Many thanks to @AntiAnti for doing the initial SP port and for the additions to the weather code.