Add OpenJO build to GitHub actions #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razish
commented
Sep 27, 2023
Razish
commented
Sep 28, 2023
taysta
suggested changes
Oct 1, 2023
taysta
approved these changes
Oct 2, 2023
…nd strip them from the official release anyway :')
Razish
force-pushed
the
add-openjo-build
branch
from
a1722b3
to
42c6b79
Compare
SomaZ
added a commit
to SomaZ/OpenJK
that referenced
this pull request
Oct 9, 2023
Based on: JACoders#1173
SomaZ
approved these changes
Oct 9, 2023
taysta
pushed a commit
to taysta/TaystJK
that referenced
this pull request
Oct 10, 2023
* Fix up some context usage and normalise cmake options * parallelise builds, split EternalJK steps on windows * looks like the python shell is v2 with no f-strings * alternative per-platform methods for obtaining the processor count * Add UseInternalLibs cmake option to default all libs to internal * remove unnecessary game path from create-latest step * allow changes to CMake project files to trigger builds (cherry picked from commit 137f55a)
taysta
pushed a commit
to taysta/TaystJK
that referenced
this pull request
Oct 10, 2023
* Fix up some context usage and normalise cmake options * parallelise builds, split EternalJK steps on windows * looks like the python shell is v2 with no f-strings * alternative per-platform methods for obtaining the processor count * Add UseInternalLibs cmake option to default all libs to internal * remove unnecessary game path from create-latest step * allow changes to CMake project files to trigger builds (cherry picked from commit 137f55a)
SomaZ
added a commit
to SomaZ/OpenJK
that referenced
this pull request
Oct 11, 2023
Based on: JACoders#1173
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off the work done in #1169, which
should be merged first (then rebase this).✅ has been mergedAdds OpenJO build options to existing matrix (not a new variant), adds separate packaging + upload steps.
It's not added as a new matrix entry to reduce unnecessary jobs/work. A lot of the build process will be shared, and it's already built into different target dirs.
Normalised cmake configuration options across runners.
Fixed a couple incorrect context usages:
runner.build_typeshould have beenmatrix.build_type, it was expanding to"".runner.workspaceshould probably begithub.workspace: github contextTODO
UseInternalLibs, it doesn't exist in OJK. May need to specify exactly which libs.cmake --buildsteps? We have at least 2 coresFuture work
OpenGL_GL_PREFERENCE=GLVND? It is defaulting to legacy GL libs currently.