Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to result first #305

Conversation

tomohisa
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Changed to result first

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@tomohisa tomohisa linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@tomohisa tomohisa merged commit f0a8b94 into main Jun 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internally, ResultBoxes should be the main usage ( to make it fast )
1 participant