Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres needs s3 #262

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Postgres needs s3 #262

merged 4 commits into from
Mar 5, 2024

Conversation

tomohisa
Copy link
Contributor

@tomohisa tomohisa commented Mar 5, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Seperate Dynamo and S3 project and Postgres can load S3

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No, and this is why: current test covers
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@tomohisa tomohisa linked an issue Mar 5, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomohisa tomohisa requested a review from tkawae March 5, 2024 02:30
Copy link
Collaborator

@tkawae tkawae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this pull request. I've reviewed the changes and I think they look great.

@tomohisa tomohisa merged commit 0907e2f into main Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres needs s3
2 participants