Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI #8

Merged
merged 95 commits into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
53552a1
Add spell checker and markdownlint
J-Afzal Dec 15, 2024
a4bd3d2
Create .gitattributes
J-Afzal Dec 16, 2024
ff73b05
Create .markdownlint.yml
J-Afzal Dec 16, 2024
ed017fd
Create cspell.yml
J-Afzal Dec 16, 2024
3e552c2
fix spelling
J-Afzal Dec 16, 2024
124f47d
more ci stuff
J-Afzal Dec 16, 2024
0baa14f
fix linting issues
J-Afzal Dec 16, 2024
59f299b
fix linting
J-Afzal Dec 16, 2024
6d334eb
split up steps in to separate jobs
J-Afzal Dec 16, 2024
20c7459
yaml linting
J-Afzal Dec 19, 2024
5285c4a
lint fixes
J-Afzal Dec 19, 2024
071b60f
Update continuous_integration.yml
J-Afzal Dec 19, 2024
4dfc0fa
-g flag test
J-Afzal Dec 19, 2024
c7b9055
Update continuous_integration.yml
J-Afzal Dec 19, 2024
f73976b
yml lint test
J-Afzal Dec 19, 2024
ab96f3c
undo test
J-Afzal Dec 19, 2024
76a800e
Add prettier linting
J-Afzal Dec 20, 2024
56455fa
update config
J-Afzal Dec 20, 2024
a5220e2
add check
J-Afzal Dec 20, 2024
7ace469
linting fixes
J-Afzal Dec 20, 2024
5f49c74
Update cspell.yml
J-Afzal Dec 20, 2024
91e5a1f
Add PowerShell linting
J-Afzal Dec 20, 2024
7ce2512
linting fix
J-Afzal Dec 20, 2024
a253902
add gitattributes linting
J-Afzal Dec 20, 2024
676ede9
default shell
J-Afzal Dec 20, 2024
4c50056
linting fix
J-Afzal Dec 20, 2024
1e7b14e
Update continuous_integration.yml
J-Afzal Dec 20, 2024
114b99f
make gitattributes linter a module
J-Afzal Dec 20, 2024
731d361
Update continuous_integration.yml
J-Afzal Dec 20, 2024
49bca21
Update continuous_integration.yml
J-Afzal Dec 20, 2024
3a5582e
Update .gitattributes
J-Afzal Dec 20, 2024
d818505
Update continuous_integration.yml
J-Afzal Dec 20, 2024
3d72c2c
Update Linters.psd1
J-Afzal Dec 20, 2024
b4a112e
Update continuous_integration.yml
J-Afzal Dec 21, 2024
b5fe934
clean up and test
J-Afzal Dec 21, 2024
ebd16bb
Update Linters.psm1
J-Afzal Dec 21, 2024
65f6575
Update Linters.psm1
J-Afzal Dec 21, 2024
fca434c
Update Linters.psm1
J-Afzal Dec 21, 2024
4f6ee16
enable debugging
J-Afzal Dec 21, 2024
21f3d74
non verbose for non debug
J-Afzal Dec 21, 2024
75df40b
better error messages
J-Afzal Dec 21, 2024
49f16b6
Update Linters.psm1
J-Afzal Dec 21, 2024
ceb1db1
fix linting
J-Afzal Dec 21, 2024
0ffa7fb
fix linting
J-Afzal Dec 21, 2024
df5c26a
Update Linters.psm1
J-Afzal Dec 21, 2024
d3a8005
add c++ linting
J-Afzal Dec 21, 2024
b724a68
Update continuous_integration.yml
J-Afzal Dec 21, 2024
7696933
Update continuous_integration.yml
J-Afzal Dec 22, 2024
f43801e
add c++ linting inside cmake
J-Afzal Dec 22, 2024
86bf027
linting
J-Afzal Dec 22, 2024
fed407d
Update Linters.psm1
J-Afzal Dec 22, 2024
92d2987
move to prettier
J-Afzal Dec 22, 2024
6febe33
linting fix
J-Afzal Dec 22, 2024
a4bc03b
Update README.md
J-Afzal Dec 22, 2024
f779cc2
run clang tidy manually
J-Afzal Dec 22, 2024
c5d1636
create clang-tidy script
J-Afzal Dec 23, 2024
49eeb82
Update continuous_integration.yml
J-Afzal Dec 24, 2024
7785769
Update cspell.yml
J-Afzal Dec 24, 2024
8678748
add constants
J-Afzal Dec 24, 2024
5b4efaf
include linting fixes
J-Afzal Dec 24, 2024
49aa95e
source linting fixes
J-Afzal Dec 24, 2024
7141b5f
Update .clang-tidy
J-Afzal Dec 24, 2024
e2b465c
Update main.cpp
J-Afzal Dec 24, 2024
87d7ff6
Update PageBuilder.cpp
J-Afzal Dec 24, 2024
4d941ad
Update Hangman.cpp
J-Afzal Dec 24, 2024
ddd112f
Update Battleships.cpp
J-Afzal Dec 24, 2024
1f6dc17
Update PageBuilder.cpp
J-Afzal Dec 24, 2024
143e30c
Update Linters.psm1
J-Afzal Dec 24, 2024
f75659b
fix remaining linting issues
J-Afzal Dec 24, 2024
a41cc0e
Update continuous_integration.yml
J-Afzal Dec 24, 2024
9e6522c
Update continuous_integration.yml
J-Afzal Dec 24, 2024
afe4655
Update continuous_integration.yml
J-Afzal Dec 24, 2024
192dbb9
Update continuous_integration.yml
J-Afzal Dec 24, 2024
b90124f
Update continuous_integration.yml
J-Afzal Dec 24, 2024
5a4ab3a
Update continuous_integration.yml
J-Afzal Dec 24, 2024
5818f49
Update continuous_integration.yml
J-Afzal Dec 24, 2024
d3e833f
Update continuous_integration.yml
J-Afzal Dec 24, 2024
a8f751e
Update continuous_integration.yml
J-Afzal Dec 24, 2024
a2bd0c6
try get-cmake
J-Afzal Dec 24, 2024
2f8b36e
switch to nmake
J-Afzal Dec 24, 2024
fc6e446
Update continuous_integration.yml
J-Afzal Dec 24, 2024
c04ac07
Update PageBuilder.cpp
J-Afzal Dec 24, 2024
3814129
fix ci
J-Afzal Dec 24, 2024
b7b6857
Update Battleships.cpp
J-Afzal Dec 24, 2024
71f0bc9
Update continuous_integration.yml
J-Afzal Dec 24, 2024
750e904
Update Battleships.cpp
J-Afzal Dec 24, 2024
27fab4e
multi-platform support (non-functional)
J-Afzal Dec 24, 2024
bb228d2
let them decide generator
J-Afzal Dec 24, 2024
b4b8ee7
Update continuous_integration.yml
J-Afzal Dec 24, 2024
d67d814
Update continuous_integration.yml
J-Afzal Dec 24, 2024
856fbf3
Update continuous_integration.yml
J-Afzal Dec 24, 2024
0902803
Update continuous_integration.yml
J-Afzal Dec 24, 2024
d309801
Update continuous_integration.yml
J-Afzal Dec 24, 2024
463efe7
Update continuous_integration.yml
J-Afzal Dec 24, 2024
9d57cbe
Update continuous_integration.yml
J-Afzal Dec 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
let them decide generator
  • Loading branch information
J-Afzal committed Dec 24, 2024
commit bb228d2f41a1c4b18962b50b08b758f2e8426de8
2 changes: 1 addition & 1 deletion .github/workflows/continuous_integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:

- name: Configure CMake
run: |
cmake -S . -B ./build -G "Ninja" -D "CMAKE_BUILD_TYPE=Release"
cmake -S . -B ./build -D "CMAKE_BUILD_TYPE=Release"

- name: Run clang-tidy
shell: pwsh
Expand Down
1 change: 1 addition & 0 deletions source/games/Battleships.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <chrono>
#include <cmath>
#include <cstdint>
#include <format>
#include <string>
#include <thread>
#include <unordered_map>
Expand Down
2 changes: 1 addition & 1 deletion source/helpers/PageBuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ namespace TerminalGames

std::string PageBuilder::GetRemainingEmptyLines(const std::string &commonTopString, const std::string &commonBottomString) const
{
const int32_t remainingLineCount = static_cast<int32_t>(m_displayHeight) - ImplementStdCount(commonTopString.begin(), commonTopString.end(), '\n') - ImplementStdCount(commonBottomString.begin(), commonBottomString.end(), '\n');
const int32_t remainingLineCount = static_cast<int32_t>(m_displayHeight) - std::count(commonTopString.begin(), commonTopString.end(), '\n') - std::count(commonBottomString.begin(), commonBottomString.end(), '\n');
const uint32_t emptyLinesToAddCount = remainingLineCount < 0 ? 0 : remainingLineCount;

std::string output;
Expand Down
Loading