Skip to content

Commit

Permalink
customserver: fix minor memory leak (ArchipelagoMW#3636)
Browse files Browse the repository at this point in the history
Old code keeps ref to last started room's task and thus never fully cleans it up.
  • Loading branch information
black-sliver authored Jul 14, 2024
1 parent 187f9da commit 948f50f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions WebHostLib/customserver.py
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,7 @@ def run(self):
self._tasks.append(task)
task.add_done_callback(self._done)
logging.info(f"Starting room {next_room} on {name}.")
del task # delete reference to task object

starter = Starter()
starter.daemon = True
Expand Down

0 comments on commit 948f50f

Please sign in to comment.