-
Notifications
You must be signed in to change notification settings - Fork 40
[MOB-11955] configure-new-architecture #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lposen
merged 13 commits into
new-arch/master
from
new-arch/MOB-11955-configure-new-architecture
Sep 5, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d00e31d
refactor: split packages between old and new architecture
lposen 0b1ed47
chore: update Android Gradle properties for Kotlin and SDK versions
lposen b33941c
refactor: enhance Android build configuration for new architecture su…
lposen 6acab23
refactor: remove deprecated imports in RNIterableAPIPackage for clean…
lposen f45c778
refactor: made newarch and oldarch structure more closely represent i…
lposen 0bb7151
Merge branch 'new-arch/MOB-11954-extract-rniterableapimodule-so-that-…
lposen 7336f84
refactor: transition RNIterableAPIPackage to extend BaseReactPackage
lposen 9a75762
chore: set group ID and modify example AndroidManifest.xml for notifi…
lposen ac23ec2
refactor: removed unused dependencies
lposen fa2b756
2.0.3-alpha.0
lposen 53b12c3
2.0.3-alpha.1
lposen 61ec865
chore: downgrade version from 2.0.3-alpha.1 to 2.0.2
lposen b042322
Merge branch 'new-arch/master' into new-arch/MOB-11955-configure-new-…
lposen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| RNIterable_kotlinVersion=1.7.0 | ||
| RNIterable_minSdkVersion=21 | ||
| RNIterable_targetSdkVersion=31 | ||
| RNIterable_compileSdkVersion=31 | ||
| RNIterable_ndkversion=21.4.7075529 | ||
| RNIterable_kotlinVersion=2.0.21 | ||
| RNIterable_minSdkVersion=24 | ||
| RNIterable_targetSdkVersion=35 | ||
| RNIterable_compileSdkVersion=35 | ||
| RNIterable_ndkversion=27.1.12297006 | ||
| android.useAndroidX=true | ||
| android.enableJetifier=true | ||
| android.enableJetifier=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 changes: 34 additions & 17 deletions
51
android/src/main/java/com/iterable/reactnative/RNIterableAPIPackage.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,29 +1,46 @@ | ||
| package com.iterable.reactnative; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Arrays; | ||
| import java.util.Collections; | ||
| import java.util.List; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import com.facebook.react.ReactPackage; | ||
| import androidx.annotation.NonNull; | ||
| import androidx.annotation.Nullable; | ||
| import com.facebook.react.BaseReactPackage; | ||
| import com.facebook.react.bridge.NativeModule; | ||
| import com.facebook.react.bridge.ReactApplicationContext; | ||
| import com.facebook.react.uimanager.ViewManager; | ||
| import com.facebook.react.bridge.JavaScriptModule; | ||
| import com.facebook.react.module.model.ReactModuleInfo; | ||
| import com.facebook.react.module.model.ReactModuleInfoProvider; | ||
|
|
||
| public class RNIterableAPIPackage implements ReactPackage { | ||
| public class RNIterableAPIPackage extends BaseReactPackage { | ||
| @Nullable | ||
| @Override | ||
| public List<NativeModule> createNativeModules( | ||
| ReactApplicationContext reactContext) { | ||
| List<NativeModule> modules = new ArrayList<>(); | ||
|
|
||
| modules.add(new RNIterableAPIModule(reactContext)); | ||
|
|
||
| return modules; | ||
| public NativeModule getModule(@NonNull String name, @NonNull ReactApplicationContext reactContext) { | ||
| if (RNIterableAPIModuleImpl.NAME.equals(name)) { | ||
| return new RNIterableAPIModule(reactContext); | ||
| } else { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| @NonNull | ||
| @Override | ||
| public List<ViewManager> createViewManagers(ReactApplicationContext reactContext) { | ||
| return Collections.emptyList(); | ||
| public ReactModuleInfoProvider getReactModuleInfoProvider() { | ||
| return new ReactModuleInfoProvider() { | ||
| @NonNull | ||
| @Override | ||
| public Map<String, ReactModuleInfo> getReactModuleInfos() { | ||
| Map<String, ReactModuleInfo> moduleInfos = new HashMap<>(); | ||
| boolean isTurboModule = BuildConfig.IS_NEW_ARCHITECTURE_ENABLED; | ||
| moduleInfos.put(RNIterableAPIModuleImpl.NAME, new ReactModuleInfo( | ||
| RNIterableAPIModuleImpl.NAME, | ||
| RNIterableAPIModuleImpl.NAME, | ||
| false, // canOverrideExistingModule | ||
| false, // needsEagerInit | ||
| false, // isCxxModule | ||
| isTurboModule // isTurboModule | ||
| )); | ||
| return moduleInfos; | ||
| } | ||
| }; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this line doing? Getting the project name from new arch vs. old arch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No -- it's either getting the value of a parameter in the users app or, if it doesn't exist, getting the value in our sdk