[MOB-11954] restructure RNIterableAPIModule to delegate functionality to RNIterableAPIModuleImpl #693

lposen · 2025-08-21T22:05:29Z

🔹 JIRA Ticket(s) if any

MOB-11954

✏️ Description

Restructure RNIterableAPIModule to delegate functionality to RNIterableAPIModuleImpl. This is to minimize duplicate code when splitting the functionality between new architecture and legacy architecture later on.

Testing

Testing Legacy Architecture

Enable Legacy Architecture:

# Check example/android/gradle.properties
newArchEnabled=false

Build and run:

cd example
cd android && ./gradlew clean && cd ..
watchman watch-del-all
yarn start --reset-cache

# In another terminal:
yarn android

Verify app launches and do a quick click through of various items

Testing New Architecture

Enable new architecture:

# Edit example/android/gradle.properties
newArchEnabled=true

Clean and rebuild:

cd example
cd android && ./gradlew clean && cd ..
watchman watch-del-all
yarn start --reset-cache

# In another terminal:
yarn android

Verify app launches and do a quick click through of various items

…o RNIterableAPIModuleImpl

Copilot

Pull Request Overview

This PR restructures the RNIterableAPIModule to delegate its functionality to a new RNIterableAPIModuleImpl class. This refactoring separates the React Native bridge interface from the core implementation logic, preparing for future architectural changes that will split functionality between new and legacy architectures.

Extracts all implementation logic from RNIterableAPIModule into RNIterableAPIModuleImpl
Transforms RNIterableAPIModule into a thin wrapper that delegates calls to the implementation
Maintains the same public API while enabling code reuse for upcoming architecture splits

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
RNIterableAPIModuleImpl.java	New implementation class containing all the core functionality moved from RNIterableAPIModule
RNIterableAPIModule.java	Refactored to delegate all method calls to RNIterableAPIModuleImpl instance

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

Copilot · 2025-08-21T22:06:19Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

    }

-    @Override
    public void onInboxUpdated() {


The onInboxUpdated method should not be public as it appears to be a callback method that should only be called internally. This method should have package-private or private visibility.

Suggested change

public void onInboxUpdated() {

void onInboxUpdated() {

github-actions · 2025-08-21T22:06:46Z

Lines	Statements	Branches	Functions
	37.98% (177/466)	13.04% (24/184)	32.9% (51/155)

qlty-cloud-legacy · 2025-08-21T22:07:38Z

11 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 5): initialize2WithApiKey	9
qlty	Structure	Function with high complexity (count = 5): initializeWithApiKey	2

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-        // This is just here to match the TS types and let the JS thread know when we are done initializing
-        promise.resolve(true);
+    @ReactMethod
+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {


Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

    @ReactMethod
-    public void trackPushOpenWithCampaignId(Integer campaignId, Integer templateId, String messageId, Boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId(campaignId, templateId, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-                finalCampaignId,
-                finalTemplateId
-        );
+    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-        }
-
-        IterableApi.getInstance().trackInAppClose(inAppMessage, clickedUrl, closeAction, inAppCloseLocation);
+    public void trackInAppClose(String messageId, double location, double source, @Nullable String clickedUrl) {


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+    public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, String version, Promise promise) {
+        IterableLogger.d(TAG, "initializeWithApiKey: " + apiKey);
+        IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
+
+        if (configReadableMap.hasKey("urlHandlerPresent") && configReadableMap.getBoolean("urlHandlerPresent") == true) {
+            configBuilder.setUrlHandler(this);
+        }
+
+        if (configReadableMap.hasKey("customActionHandlerPresent") && configReadableMap.getBoolean("customActionHandlerPresent") == true) {
+            configBuilder.setCustomActionHandler(this);
+        }
+
+        if (configReadableMap.hasKey("inAppHandlerPresent") && configReadableMap.getBoolean("inAppHandlerPresent") == true) {
+            configBuilder.setInAppHandler(this);
+        }
+
+        if (configReadableMap.hasKey("authHandlerPresent") && configReadableMap.getBoolean("authHandlerPresent") == true) {
+            configBuilder.setAuthHandler(this);
+        }
+
+        IterableApi.initialize(reactContext, apiKey, configBuilder.build());
+        IterableApi.getInstance().setDeviceAttribute("reactNativeSDKVersion", version);
+
+        IterableApi.getInstance().getInAppManager().addListener(this);
+
+        // MOB-10421: Figure out what the error cases are and handle them appropriately
+        // This is just here to match the TS types and let the JS thread know when we are done initializing
+        promise.resolve(true);


Found 2 issues:

1. Function with high complexity (count = 5): initializeWithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 4): initializeWithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
+        IterableLogger.d(TAG, "initialize2WithApiKey: " + apiKey);
+        IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
+
+        if (configReadableMap.hasKey("urlHandlerPresent") && configReadableMap.getBoolean("urlHandlerPresent") == true) {
+            configBuilder.setUrlHandler(this);
+        }
+
+        if (configReadableMap.hasKey("customActionHandlerPresent") && configReadableMap.getBoolean("customActionHandlerPresent") == true) {
+            configBuilder.setCustomActionHandler(this);
+        }
+
+        if (configReadableMap.hasKey("inAppHandlerPresent") && configReadableMap.getBoolean("inAppHandlerPresent") == true) {
+            configBuilder.setInAppHandler(this);
+        }
+
+        if (configReadableMap.hasKey("authHandlerPresent") && configReadableMap.getBoolean("authHandlerPresent") == true) {
+            configBuilder.setAuthHandler(this);
+        }
+
+        // Set the API endpoint override if provided
+        // if (apiEndPointOverride != null && !apiEndPointOverride.isEmpty()) {
+        //     configBuilder.setApiEndpoint(apiEndPointOverride);
+        // }
+
+        IterableApi.initialize(reactContext, apiKey, configBuilder.build());
+        IterableApi.getInstance().setDeviceAttribute("reactNativeSDKVersion", version);
+
+        IterableApi.getInstance().getInAppManager().addListener(this);
+
+        // MOB-10421: Figure out what the error cases are and handle them appropriately
+        // This is just here to match the TS types and let the JS thread know when we are done initializing
+        promise.resolve(true);


Found 2 issues:

1. Function with high complexity (count = 5): initialize2WithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
+    }
+
+    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
+    }
+
+    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:07:39Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        IterableApi.getInstance().trackInAppClick(message, clickedUrl, inAppOpenLocation);
+    }
+
+    public void trackInAppClose(String messageId, double location, double source, @Nullable String clickedUrl) {


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

…ride limitations

…for cleaner code

qlty-cloud-legacy · 2025-08-21T22:21:30Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-        // This is just here to match the TS types and let the JS thread know when we are done initializing
-        promise.resolve(true);
+    @ReactMethod
+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {


Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:30Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

    @ReactMethod
-    public void trackPushOpenWithCampaignId(Integer campaignId, Integer templateId, String messageId, Boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId(campaignId, templateId, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:30Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-                finalCampaignId,
-                finalTemplateId
-        );
+    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:30Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-        }
-
-        IterableApi.getInstance().trackInAppClose(inAppMessage, clickedUrl, closeAction, inAppCloseLocation);
+    public void trackInAppClose(String messageId, double location, double source, @Nullable String clickedUrl) {


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:30Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+    public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, String version, Promise promise) {
+        IterableLogger.d(TAG, "initializeWithApiKey: " + apiKey);
+        IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
+
+        if (configReadableMap.hasKey("urlHandlerPresent") && configReadableMap.getBoolean("urlHandlerPresent") == true) {
+            configBuilder.setUrlHandler(this);
+        }
+
+        if (configReadableMap.hasKey("customActionHandlerPresent") && configReadableMap.getBoolean("customActionHandlerPresent") == true) {
+            configBuilder.setCustomActionHandler(this);
+        }
+
+        if (configReadableMap.hasKey("inAppHandlerPresent") && configReadableMap.getBoolean("inAppHandlerPresent") == true) {
+            configBuilder.setInAppHandler(this);
+        }
+
+        if (configReadableMap.hasKey("authHandlerPresent") && configReadableMap.getBoolean("authHandlerPresent") == true) {
+            configBuilder.setAuthHandler(this);
+        }
+
+        IterableApi.initialize(reactContext, apiKey, configBuilder.build());
+        IterableApi.getInstance().setDeviceAttribute("reactNativeSDKVersion", version);
+
+        IterableApi.getInstance().getInAppManager().addListener(this);
+
+        // MOB-10421: Figure out what the error cases are and handle them appropriately
+        // This is just here to match the TS types and let the JS thread know when we are done initializing
+        promise.resolve(true);


Found 2 issues:

1. Function with high complexity (count = 5): initializeWithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 4): initializeWithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:30Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
+        IterableLogger.d(TAG, "initialize2WithApiKey: " + apiKey);
+        IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
+
+        if (configReadableMap.hasKey("urlHandlerPresent") && configReadableMap.getBoolean("urlHandlerPresent") == true) {
+            configBuilder.setUrlHandler(this);
+        }
+
+        if (configReadableMap.hasKey("customActionHandlerPresent") && configReadableMap.getBoolean("customActionHandlerPresent") == true) {
+            configBuilder.setCustomActionHandler(this);
+        }
+
+        if (configReadableMap.hasKey("inAppHandlerPresent") && configReadableMap.getBoolean("inAppHandlerPresent") == true) {
+            configBuilder.setInAppHandler(this);
+        }
+
+        if (configReadableMap.hasKey("authHandlerPresent") && configReadableMap.getBoolean("authHandlerPresent") == true) {
+            configBuilder.setAuthHandler(this);
+        }
+
+        // NOTE: There does not seem to be a way to set the API endpoint
+        // override in the Android SDK.  Check with @Ayyanchira and @evantk91 to
+        // see what the best approach is.
+
+        IterableApi.initialize(reactContext, apiKey, configBuilder.build());
+        IterableApi.getInstance().setDeviceAttribute("reactNativeSDKVersion", version);
+
+        IterableApi.getInstance().getInAppManager().addListener(this);
+
+        // MOB-10421: Figure out what the error cases are and handle them appropriately
+        // This is just here to match the TS types and let the JS thread know when we are done initializing
+        promise.resolve(true);


Found 2 issues:

1. Function with high complexity (count = 5): initialize2WithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:31Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
+    }
+
+    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:31Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
+    }
+
+    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-21T22:21:31Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        IterableApi.getInstance().trackInAppClick(message, clickedUrl, inAppOpenLocation);
+    }
+
+    public void trackInAppClose(String messageId, double location, double source, @Nullable String clickedUrl) {


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

…ableapimodule-so-that-its-major-func

qlty-cloud-legacy · 2025-08-28T20:14:34Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-        // This is just here to match the TS types and let the JS thread know when we are done initializing
-        promise.resolve(true);
+    @ReactMethod
+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {


Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:34Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

    @ReactMethod
-    public void trackPushOpenWithCampaignId(Integer campaignId, Integer templateId, String messageId, Boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId(campaignId, templateId, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:34Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-                finalCampaignId,
-                finalTemplateId
-        );
+    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:34Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModule.java

-        }
-
-        IterableApi.getInstance().trackInAppClose(inAppMessage, clickedUrl, closeAction, inAppCloseLocation);
+    public void trackInAppClose(String messageId, double location, double source, @Nullable String clickedUrl) {


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:34Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+    public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, String version, Promise promise) {
+        IterableLogger.d(TAG, "initializeWithApiKey: " + apiKey);
+        IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
+
+        if (configReadableMap.hasKey("urlHandlerPresent") && configReadableMap.getBoolean("urlHandlerPresent") == true) {
+            configBuilder.setUrlHandler(this);
+        }
+
+        if (configReadableMap.hasKey("customActionHandlerPresent") && configReadableMap.getBoolean("customActionHandlerPresent") == true) {
+            configBuilder.setCustomActionHandler(this);
+        }
+
+        if (configReadableMap.hasKey("inAppHandlerPresent") && configReadableMap.getBoolean("inAppHandlerPresent") == true) {
+            configBuilder.setInAppHandler(this);
+        }
+
+        if (configReadableMap.hasKey("authHandlerPresent") && configReadableMap.getBoolean("authHandlerPresent") == true) {
+            configBuilder.setAuthHandler(this);
+        }
+
+        IterableApi.initialize(reactContext, apiKey, configBuilder.build());
+        IterableApi.getInstance().setDeviceAttribute("reactNativeSDKVersion", version);
+
+        IterableApi.getInstance().getInAppManager().addListener(this);
+
+        // MOB-10421: Figure out what the error cases are and handle them appropriately
+        // This is just here to match the TS types and let the JS thread know when we are done initializing
+        promise.resolve(true);


Found 2 issues:

1. Function with high complexity (count = 5): initializeWithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 4): initializeWithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:35Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
+        IterableLogger.d(TAG, "initialize2WithApiKey: " + apiKey);
+        IterableConfig.Builder configBuilder = Serialization.getConfigFromReadableMap(configReadableMap);
+
+        if (configReadableMap.hasKey("urlHandlerPresent") && configReadableMap.getBoolean("urlHandlerPresent") == true) {
+            configBuilder.setUrlHandler(this);
+        }
+
+        if (configReadableMap.hasKey("customActionHandlerPresent") && configReadableMap.getBoolean("customActionHandlerPresent") == true) {
+            configBuilder.setCustomActionHandler(this);
+        }
+
+        if (configReadableMap.hasKey("inAppHandlerPresent") && configReadableMap.getBoolean("inAppHandlerPresent") == true) {
+            configBuilder.setInAppHandler(this);
+        }
+
+        if (configReadableMap.hasKey("authHandlerPresent") && configReadableMap.getBoolean("authHandlerPresent") == true) {
+            configBuilder.setAuthHandler(this);
+        }
+
+        // NOTE: There does not seem to be a way to set the API endpoint
+        // override in the Android SDK.  Check with @Ayyanchira and @evantk91 to
+        // see what the best approach is.
+
+        IterableApi.initialize(reactContext, apiKey, configBuilder.build());
+        IterableApi.getInstance().setDeviceAttribute("reactNativeSDKVersion", version);
+
+        IterableApi.getInstance().getInAppManager().addListener(this);
+
+        // MOB-10421: Figure out what the error cases are and handle them appropriately
+        // This is just here to match the TS types and let the JS thread know when we are done initializing
+        promise.resolve(true);


Found 2 issues:

1. Function with high complexity (count = 5): initialize2WithApiKey [qlty:function-complexity]

2. Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:35Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
+    }
+
+    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:35Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
+    }
+
+    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:14:35Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

+        IterableApi.getInstance().trackInAppClick(message, clickedUrl, inAppOpenLocation);
+    }
+
+    public void trackInAppClose(String messageId, double location, double source, @Nullable String clickedUrl) {


Function with many parameters (count = 4): trackInAppClose [qlty:function-parameters]

evantk91

Just skimmed. Let me know if you need a deeper review. Confirmed both legacy and new architecture run successfully.

refactor: restructure RNIterableAPIModule to delegate functionality t…

a7b0577

…o RNIterableAPIModuleImpl

lposen marked this pull request as ready for review August 21, 2025 22:05

lposen requested a review from Copilot August 21, 2025 22:05

Copilot AI reviewed Aug 21, 2025

View reviewed changes

qlty-cloud-legacy bot reviewed Aug 21, 2025

View reviewed changes

lposen added 2 commits August 21, 2025 15:16

refactor: update RNIterableAPIModuleImpl to clarify API endpoint over…

b96c217

…ride limitations

refactor: remove unnecessary access modifiers in RNIterableAPIModule …

1086a77

…for cleaner code

qlty-cloud-legacy bot reviewed Aug 21, 2025

View reviewed changes

Merge branch 'new-arch/master' into new-arch/MOB-11954-extract-rniter…

d3578f6

…ableapimodule-so-that-its-major-func

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

evantk91 approved these changes Aug 29, 2025

View reviewed changes

lposen merged commit e7eec5d into new-arch/master Sep 3, 2025
5 checks passed

lposen deleted the new-arch/MOB-11954-extract-rniterableapimodule-so-that-its-major-func branch September 3, 2025 00:17

lposen mentioned this pull request Oct 14, 2025

[SDK-82] New Architecture #704

Merged

[MOB-11954] restructure RNIterableAPIModule to delegate functionality to RNIterableAPIModuleImpl #693

[MOB-11954] restructure RNIterableAPIModule to delegate functionality to RNIterableAPIModuleImpl #693

Uh oh!

Conversation

lposen commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Testing Legacy Architecture

Testing New Architecture

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qlty-cloud-legacy bot commented Aug 21, 2025

11 new issues

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 21, 2025

Choose a reason for hiding this comment

lposen commented Aug 21, 2025 •

edited

Loading

github-actions bot commented Aug 21, 2025 •

edited

Loading

evantk91 left a comment •

edited

Loading