Skip to content

[MOB-8751] create embedded manager #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 6, 2025
Merged

[MOB-8751] create embedded manager #646

merged 2 commits into from
Jun 6, 2025

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jun 4, 2025 •
edited
Loading

🔹 JIRA Ticket(s) if any

✏️ Description

This pull request

  • creates the IterableEmbeddedManager
  • creates getPlacements on IterableEmbeddedManager
  • creates getEmbeddedPlacements on RNIterableAPIModule and ReactIterableAPI

Testing:

  • native functions have hard coded dummy placements
  • the dev app has "get embedded messages" added to the api list under the embedded-testing branch
  • you can test passing through embedded placments by changing the hardcoded payload and verifying that it shows up on the app side
  • unit tests will be added once the embedded placement class is created on the next PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025 •
edited
Loading

Lines Statements Branches Functions
Coverage: 38%
 38% (179/471) 11.29% (20/177) 32.05% (50/156)

@evantk91 evantk91 changed the title [MOB-8751] feat: updates bridge [MOB-8751] create embedded manager Jun 4, 2025
@evantk91 evantk91 changed the base branch from master to evan/feature/embedded June 4, 2025 20:39
@evantk91 evantk91 requested a review from lposen June 4, 2025 20:51
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 4, 2025

❌ 4 blocking issues (4 total)

Tool Category Rule Count
eslint Lint Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
4 ❌

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

codeclimate[bot]
codeclimate bot reviewed Jun 4, 2025
View reviewed changes
src/embedded/classes/IterableEmbeddedManager.ts
@@ -0,0 +1,24 @@
import { NativeModules } from 'react-native';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/embedded/classes/IterableEmbeddedPlacement.ts
@@ -0,0 +1,11 @@
/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/embedded/classes/index.ts
@@ -0,0 +1,2 @@
export * from './IterableEmbeddedManager';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

src/embedded/index.ts
@@ -0,0 +1 @@
export * from './classes';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

lposen
lposen approved these changes Jun 6, 2025
View reviewed changes
Copy link
Contributor

@lposen lposen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@evantk91 evantk91 merged commit 5164c44 into evan/feature/embedded Jun 6, 2025
4 of 5 checks passed
@evantk91 evantk91 deleted the evan/MOB-8751 branch June 6, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

@lposen lposen lposen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evantk91 @lposen