[MOB-9235] Fix variable IV length issue #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantk91
approved these changes
Jan 2, 2025
Contributor
evantk91
left a comment
evantk91
left a comment
There was a problem hiding this comment.
Added some clarifications
| combined[0] = if (encryptedData.isModernEncryption) 1 else 0 | ||
| System.arraycopy(encryptedData.iv, 0, combined, 1, encryptedData.iv.size) | ||
| System.arraycopy(encryptedData.data, 0, combined, 1 + encryptedData.iv.size, encryptedData.data.size) | ||
| combined[1] = encryptedData.iv.size.toByte() // Store IV length |
Contributor
There was a problem hiding this comment.
I see IV length is pulled from data instead of being hardcoded.
Collaborator
Author
There was a problem hiding this comment.
right so we have variable iv lenghts and we encode it
Collaborator
Author
There was a problem hiding this comment.
and then when we decode it we know what the iv length was
| val cipher = Cipher.getInstance(TRANSFORMATION_MODERN) | ||
| val iv = generateIV() | ||
| val spec = GCMParameterSpec(GCM_TAG_LENGTH, iv) | ||
| cipher.init(Cipher.ENCRYPT_MODE, getKey(), spec) |
Contributor
There was a problem hiding this comment.
Why is generateIV removed here? Seems like it should follow encrypt legacy but with modern set to true
Collaborator
Author
There was a problem hiding this comment.
in modern we dont generate instead we let android generate it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Variable IV Length Issue