Skip to content

Conversation

@Ayyanchira
Copy link
Member

@Ayyanchira Ayyanchira commented Dec 2, 2024

🔹 Jira Ticket(s) if any

✏️ Description

This fix makes the IterableInboxFragment adjust with window insets allowing full screen apps to take advantage of IterableInboxActivity or IterableInboxFragment. As IterableInboxActivity internally launches IterableFragment, the changes in Fragment is sufficient to make up for cut outs and notches on displays

This fix makes the IterableInboxFragment adjust with window insets allowing full screen apps to take advantage of IterableInboxActivity or IterableInboxFragment.
As IterableInboxActivity internally launches IterableFragment, the changes in Fragment is sufficient to make up for cut outs and notches on displays
@Ayyanchira Ayyanchira requested a review from evantk91 December 2, 2024 15:31
Copy link
Contributor

@evantk91 evantk91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Updating Github action to use MacOS 13 as mac os 12 is deprecated now.
updating java version for instrumentation test
@Ayyanchira Ayyanchira merged commit f54e812 into master Dec 11, 2024
4 checks passed
@Ayyanchira Ayyanchira deleted the MOB-9111-Inbox-Overlaps-OnNotch-Android35 branch December 11, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants