Skip to content

Conversation

@vbabenkoru
Copy link
Contributor

@vbabenkoru vbabenkoru commented Dec 20, 2018

Add public methods to be called from a custom FirebaseMessagingService subclass if the app has one.

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #71 into master will decrease coverage by 0.35%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   61.65%   61.29%   -0.36%     
==========================================
  Files          26       26              
  Lines        1536     1545       +9     
  Branches      157      160       +3     
==========================================
  Hits          947      947              
- Misses        483      490       +7     
- Partials      106      108       +2
Impacted Files Coverage Δ
...iterableapi/IterableFirebaseInstanceIDService.java 0% <0%> (ø) ⬆️
...ain/java/com/iterable/iterableapi/IterableApi.java 55.27% <0%> (-0.23%) ⬇️
...rable/iterableapi/IterableNotificationBuilder.java 77.29% <0%> (-0.43%) ⬇️
.../iterableapi/IterableFirebaseMessagingService.java 54.83% <54.54%> (-8.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99dfb6c...98348e3. Read the comment docs.

Copy link

@tapashmajumder tapashmajumder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vbabenkoru vbabenkoru merged commit bff1ce9 into master Jan 2, 2019
@vbabenkoru vbabenkoru deleted the feature/MOB-109-custom-firebase-service-support branch April 1, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants