Skip to content

Conversation

@evantk91
Copy link
Contributor

@evantk91 evantk91 commented Nov 12, 2023

🔹 Jira Ticket(s) if any

✏️ Description

This pull request implements JWT retry logic. Credit: Omni-CG.

@davidtruong davidtruong added the omni-cg PR's from OMNI CG label Nov 13, 2023
@evantk91 evantk91 requested a review from vbabenkoru November 14, 2023 18:08
@codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (7ee5748) 61.90% compared to head (36389f3) 62.50%.

❗ Current head 36389f3 differs from pull request most recent head 7a8d798. Consider uploading reports for the commit 7a8d798 to get more accurate results

Files Patch % Lines
.../com/iterable/iterableapi/IterableAuthManager.java 51.42% 16 Missing and 1 partial ⚠️
.../com/iterable/iterableapi/IterableRequestTask.java 57.89% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   61.90%   62.50%   +0.59%     
==========================================
  Files          70       70              
  Lines        4127     4163      +36     
  Branches      481      479       -2     
==========================================
+ Hits         2555     2602      +47     
+ Misses       1311     1297      -14     
- Partials      261      264       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@evantk91 evantk91 requested a review from mprew97 November 14, 2023 21:54
@evantk91 evantk91 requested a review from mprew97 November 15, 2023 16:02
@evantk91 evantk91 requested a review from jyu115 November 15, 2023 16:43
Copy link
Contributor

@jyu115 jyu115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

walked through test cases with evan

@evantk91 evantk91 merged commit 4bed13d into master Nov 15, 2023
@evantk91 evantk91 deleted the evan/MOB-7154-jwt-retry-omni branch November 15, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

omni-cg PR's from OMNI CG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants