ITBL-1286 Supports messageID for push opens on android. #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return this.templateId; | ||
| } | ||
|
|
||
| public String getMessageId() { return this.messageId; } |
There was a problem hiding this comment.
this should be fine going forward right? before we make the change on the server, the messageId won't exist yet. so... does this need to be made an option? or we just synchronize our deploy of server code with release of SDK update?
Contributor
Author
There was a problem hiding this comment.
The server code should go out first since the old SDK won't process anything related to messageID. I'll deploy the mobile SDKs afterward.
|
a few questions/comments, otherwise LFTM |
| IterableNotificationData iterableNotificationData = new IterableNotificationData(iterableDataString); | ||
| if (IterableApi.sharedInstance != null) { | ||
| IterableApi.sharedInstance.setNotificationData(iterableNotificationData); | ||
| IterableApi.sharedInstance.trackPushOpen(iterableNotificationData.getCampaignId(), iterableNotificationData.getTemplateId()); |
Contributor
There was a problem hiding this comment.
seems like it would make sense to use the iterableNotificationData that you just set? Or pass in the whole object? Rather than each param? But this is fine too
Contributor
|
lftm |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android support for messageID.