[MOB-5934] set base endpoint based on config #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## eudc-updates #549 +/- ##
===============================================
Coverage ? 44.12%
===============================================
Files ? 68
Lines ? 3973
Branches ? 461
===============================================
Hits ? 1753
Misses ? 2013
Partials ? 207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Ayyanchira
approved these changes
Apr 18, 2023
| IterableLogger.v(TAG, ">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>\n"); | ||
| String baseUrl = (iterableApiRequest.baseUrl != null && !iterableApiRequest.baseUrl.isEmpty()) ? iterableApiRequest.baseUrl : | ||
| ITERABLE_BASE_URL; | ||
| String baseUrl = getBaseUrl(); |
| */ | ||
| class IterableRequestTask extends AsyncTask<IterableApiRequest, Void, IterableApiResponse> { | ||
| static final String TAG = "IterableRequest"; | ||
| static final String ITERABLE_BASE_URL = "https://api.iterable.com/api/"; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
This pull request puts logic setting base url in a separate method and sets the base url based on the data region config value.