Skip to content

Conversation

@vbabenkoru
Copy link
Contributor

🔹 Jira Ticket(s) if any

✏️ Description

Add a test to make sure PendingIntent.FLAG_IMMUTABLE is present in both the content intent and action (button) intents to prevent any future regressions due to this flag being missing.

@vbabenkoru
Copy link
Contributor Author

This is a matching test for the fix in #418.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #420 (cdf99c4) into master (ad9b830) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   66.68%   66.86%   +0.18%     
==========================================
  Files          65       65              
  Lines        3863     3863              
  Branches      449      449              
==========================================
+ Hits         2576     2583       +7     
+ Misses       1023     1018       -5     
+ Partials      264      262       -2     
Impacted Files Coverage Δ
...ain/java/com/iterable/iterableapi/IterableApi.java 65.02% <0.00%> (+0.25%) ⬆️
...com/iterable/iterableapi/IterableInAppManager.java 88.57% <0.00%> (+0.47%) ⬆️
...in/java/com/iterable/iterableapi/IterableUtil.java 67.50% <0.00%> (+2.50%) ⬆️
.../iterable/iterableapi/IterableActivityMonitor.java 95.08% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9b830...cdf99c4. Read the comment docs.

Copy link
Contributor

@davidtruong davidtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbabenkoru vbabenkoru merged commit 229867f into master Jan 14, 2022
@vbabenkoru vbabenkoru deleted the feature/MOB-3897-add-regression-test-for-immutable branch January 14, 2022 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants