[MOB - 3703] - Sensitive log information #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Additional check to see if the App is debuggable. If so, only then -> consider config.logLevel or else, stick with default -> or anything above Warning level
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 67.35% 67.30% -0.05%
==========================================
Files 63 63
Lines 3795 3802 +7
Branches 439 440 +1
==========================================
+ Hits 2556 2559 +3
- Misses 981 982 +1
- Partials 258 261 +3
Continue to review full report at Codecov.
|
Ayyanchira
force-pushed
the
MOB-3703-Iterable-Logging-Senstive-Data
branch
from
5ce9a74 to
9fe905d
Compare
Ayyanchira
force-pushed
the
MOB-3703-Iterable-Logging-Senstive-Data
branch
from
9fe905d to
121694a
Compare
roninopf
reviewed
Nov 17, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableRequestTask.java
Show resolved
Hide resolved
roninopf
reviewed
Nov 17, 2021
| } | ||
|
|
||
| private static boolean isLoggable(int messageLevel) { | ||
| boolean isDebug = ((IterableApi.getInstance().getMainActivityContext().getApplicationInfo().flags & IterableApi.getInstance().getMainActivityContext().getApplicationInfo().FLAG_DEBUGGABLE) != 0); |
Contributor
There was a problem hiding this comment.
Not needed for approval, should isDebug be split out as a universal utility function?
Member
Author
There was a problem hiding this comment.
In fact we do have a global state in IterableAPI class which is referred in IterableLogger. However, I dont see setDebugMode called anywhere in the code.
This PR will add explicit check. But will give it a look if it can be optimized 👍
roninopf
approved these changes
Nov 17, 2021
Added checks to omit Auth key and API key before logging
Ayyanchira
force-pushed
the
MOB-3703-Iterable-Logging-Senstive-Data
branch
from
121694a to
09302b2
Compare
vbabenkoru
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
(https://iterable.atlassian.net/browse/MOB-XXXX)](https://iterable.atlassian.net/browse/MOB-3703)
✏️ Description