Skip to content

Conversation

@Ayyanchira
Copy link
Member

🔹 Jira Ticket(s) if any

https://iterable.atlassian.net/browse/MOB-3091

This is fix suggested in review: Iterable/react-native-sdk#174. This way RN Android wont need any change.

✏️ Description

syncInApp() is called right after InAppManager is initialized. SyncInApp call when switching to foreground remains unaffected. Duplicate calls will also be not made as lastSyncTime is updated inside SyncInApp call.

syncInApp() is called right after InAppManager is initialized. SyncInApp call when switching to foreground remains unaffected. Duplicate calls will also be not made as lastSyncTime is updated inside SyncInApp call.
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #371 (bf48b2e) into master (987ec0d) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   67.38%   67.60%   +0.22%     
==========================================
  Files          61       61              
  Lines        3780     3781       +1     
  Branches      440      440              
==========================================
+ Hits         2547     2556       +9     
+ Misses        969      965       -4     
+ Partials      264      260       -4     
Impacted Files Coverage Δ
...com/iterable/iterableapi/IterableInAppManager.java 88.03% <100.00%> (+0.53%) ⬆️
...va/com/iterable/iterableapi/IterableApiClient.java 76.20% <0.00%> (+0.60%) ⬆️
...ain/java/com/iterable/iterableapi/IterableApi.java 65.02% <0.00%> (+0.77%) ⬆️
.../iterable/iterableapi/IterableActivityMonitor.java 95.08% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 987ec0d...bf48b2e. Read the comment docs.

@Ayyanchira Ayyanchira merged commit 390da1e into master Aug 20, 2021
@Ayyanchira Ayyanchira deleted the MOB-3091-2-SyncInApp-with-initialization branch August 20, 2021 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants