Skip to content

Conversation

@Ayyanchira
Copy link
Member

🔹 Jira Ticket(s) if any

https://iterable.atlassian.net/browse/MOB-3238

✏️ Description

This was removed in its last iteration during the clean up of bintray related files. But looks like we need it as part for performing ./gradlew install command.

NOTE:
This is the place from where gradle gets definition of install:
https://raw.githubusercontent.com/nuuneoi/JCenter/master/installv1.gradle
This task generates pom file.

Most of the content looks similar to our existing script in maven-push.gradle file, which also generates pom file.

This was removed in its last iteration during the clean up of bintray related files. But looks like we need it as part for performing ./gradlew install command.
@Ayyanchira Ayyanchira requested a review from vbabenkoru August 3, 2021 15:00
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #365 (67d86a8) into master (ffabfe7) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 67d86a8 differs from pull request most recent head aa40a9e. Consider uploading reports for the commit aa40a9e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   67.32%   67.45%   +0.13%     
==========================================
  Files          61       61              
  Lines        3758     3758              
  Branches      438      438              
==========================================
+ Hits         2530     2535       +5     
+ Misses        966      961       -5     
  Partials      262      262              
Impacted Files Coverage Δ
.../com/iterable/iterableapi/IterableRequestTask.java 81.85% <0.00%> (+2.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffabfe7...aa40a9e. Read the comment docs.

@Ayyanchira Ayyanchira merged commit de7100c into master Aug 4, 2021
@Ayyanchira Ayyanchira deleted the MOB-3238-install-script-in-gradle branch August 4, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants