[MOB-2762] - Bug fix - In App read state #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Dont show inapp (process message) right on switching to foreground. Wait for sync to happen and it will trigger scheduleProcessing automatically.
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
==========================================
- Coverage 70.86% 70.62% -0.24%
==========================================
Files 60 60
Lines 3734 3735 +1
Branches 437 436 -1
==========================================
- Hits 2646 2638 -8
- Misses 825 831 +6
- Partials 263 266 +3
Continue to review full report at Codecov.
|
vbabenkoru
reviewed
Mar 29, 2021
iterableapi/src/main/java/com/iterable/iterableapi/IterableInAppManager.java
Show resolved
Hide resolved
1. Updated JSON used by test cases to have read state. 2. Removed syncInApp calls as it is internally triggered when app comes to foreground. 3. Schedule Processing is manually called if the app comes to foreground within 60 seconds of its last sync. 4. Schedule processing is also called when getMessage call fails. It compensates for network being offline
Ayyanchira
force-pushed
the
MOB-2762-BUG-fix-In-App-Read-State
branch
from
8829ae7 to
9bc7533
Compare
vbabenkoru
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
https://iterable.atlassian.net/browse/MOB-2762
✏️ Description