Skip to content

Conversation

@vbabenkoru
Copy link
Contributor

🔹 Jira Ticket(s) if any

✏️ Description

There was one test still using PowerMock. This PR refactors IterableActionRunner a bit to make it testable without PowerMock, and removes PowerMock dependency from our project.

@vbabenkoru vbabenkoru requested a review from Ayyanchira February 9, 2021 23:58
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #320 (438c35f) into master (dad4663) will increase coverage by 0.10%.
The diff coverage is 53.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   70.36%   70.46%   +0.10%     
==========================================
  Files          60       60              
  Lines        3698     3701       +3     
  Branches      427      430       +3     
==========================================
+ Hits         2602     2608       +6     
+ Misses        830      829       -1     
+ Partials      266      264       -2     
Impacted Files Coverage Δ
...com/iterable/iterableapi/IterableActionRunner.java 51.51% <53.12%> (+8.18%) ⬆️
.../iterable/iterableapi/IterableActivityMonitor.java 93.44% <0.00%> (+1.63%) ⬆️
...java/com/iterable/iterableapi/ui/BitmapLoader.java 64.28% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad4663...58c1a49. Read the comment docs.

@vbabenkoru vbabenkoru merged commit 423b507 into master Feb 10, 2021
@vbabenkoru vbabenkoru deleted the chore/MOB-2344-remove-powermock branch February 10, 2021 00:51
Ayyanchira added a commit that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants