-
Notifications
You must be signed in to change notification settings - Fork 33
Added Beta SDK ToS to README; added link to Iterable's Android SDK re… #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bradumbaugh
commented
May 10, 2019
- Added the Beta SDK terms of service to the README
- Added a link to Iterable's Android release notes
|
@vbabenkoru Any concerns with this? Would like to get this merged in today. |
vbabenkoru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradumbaugh Is the plan to remove this before releasing this as a stable version?
|
@vbabenkoru No; it's just it is just only applicable to beta versions. |
|
@vbabenkoru Would it be better if I added this text under the beta heading?
|
|
What do you think about having this in a separate file, like |
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 72.86% 72.86%
=======================================
Files 34 34
Lines 1924 1924
Branches 209 209
=======================================
Hits 1402 1402
Misses 386 386
Partials 136 136Continue to review full report at Codecov.
|
|
@vbabenkoru I think that's a good plan, went ahead and made that change. |
vbabenkoru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍