Skip to content

Conversation

@bradumbaugh
Copy link

  • Added the Beta SDK terms of service to the README
  • Added a link to Iterable's Android release notes

@bradumbaugh bradumbaugh requested a review from vbabenkoru May 10, 2019 00:07
@bradumbaugh
Copy link
Author

@vbabenkoru Any concerns with this? Would like to get this merged in today.

Copy link
Contributor

@vbabenkoru vbabenkoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradumbaugh Is the plan to remove this before releasing this as a stable version?

@bradumbaugh
Copy link
Author

@vbabenkoru No; it's just it is just only applicable to beta versions.

@bradumbaugh
Copy link
Author

@vbabenkoru Would it be better if I added this text under the beta heading?

The following terms of service apply to beta versions of Iterable's Android SDK

@vbabenkoru
Copy link
Contributor

What do you think about having this in a separate file, like BETA-TOS.md, and linking to it from release notes/changelogs for beta versions?

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #104 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   72.86%   72.86%           
=======================================
  Files          34       34           
  Lines        1924     1924           
  Branches      209      209           
=======================================
  Hits         1402     1402           
  Misses        386      386           
  Partials      136      136

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5028ee...48b7a6b. Read the comment docs.

@bradumbaugh
Copy link
Author

@vbabenkoru I think that's a good plan, went ahead and made that change.

Copy link
Contributor

@vbabenkoru vbabenkoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bradumbaugh bradumbaugh merged commit 1fca66d into master May 10, 2019
@bradumbaugh bradumbaugh deleted the readme-updates branch May 10, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants