Skip to content

Create a new field for internal, unresolved storage #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 4, 2020
Merged

Create a new field for internal, unresolved storage #1

merged 4 commits into from
Mar 4, 2020

Conversation

@dontgitit
Copy link

@dontgitit dontgitit commented Mar 4, 2020

No description provided.

nbaldwin
nbaldwin approved these changes Mar 4, 2020
View reviewed changes
Copy link

@nbaldwin nbaldwin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a solid solution to me, I want someone more authoritative to approve too though.

@nbaldwin
Copy link

nbaldwin commented Mar 4, 2020

@gmethvin ?

@suhel-ahmed suhel-ahmed requested a review from gmethvin March 4, 2020 00:35
gmethvin
gmethvin approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@gmethvin gmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@dontgitit dontgitit merged commit e0f7722 into master Mar 4, 2020
@dontgitit dontgitit deleted the create-internal-storage branch March 4, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmethvin gmethvin gmethvin approved these changes

@nbaldwin nbaldwin nbaldwin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dontgitit @nbaldwin @gmethvin