Add Serialized
wrapper to make it harder to accidentally deserialize the wrong type
#774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While restoring the dashboard, I realized that the comment about the type of the
Submit::serialized_desc
was wrong - it was not storingJobDescription
, butSubmitRequest
. There was also one place in the code that was deserializing this incorrect type. I created a type wrapper to make sure that this doesn't happen again.We should use the same thing for
SerializedTaskContext
, however it currently uses different bincode options (it uses fixint encoding and doesn't allow trailing bytes), so I did not use it there yet.