Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and missing quote on jobfile documentation #772

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix typo and missing quote on jobfile documentation #772

merged 1 commit into from
Oct 17, 2024

Conversation

manuel-g-castro
Copy link
Contributor

Hi! I have been studying this tool for my PhD and found two minor issues on the documentation.

Hope it helps to make this great documentation even better 😄 .

@Kobzol
Copy link
Collaborator

Kobzol commented Oct 17, 2024

Hi, thank you! The first commit looks good, but where did you find out about stream_log? The name of the attribute should be indeed stream. Maybe you're using an older HyperQueue version?

Good luck with your PhD, btw :)

@manuel-g-castro
Copy link
Contributor Author

Oh, indeed! I am using v0.18.0. Okay! I remove this last commit.

Kobzol
Kobzol approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@Kobzol Kobzol enabled auto-merge (rebase) October 17, 2024 06:31
@Kobzol Kobzol merged commit 84094f6 into It4innovations:main Oct 17, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuel-g-castro @Kobzol