Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for issue 1328. #22

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

dflitner
Copy link
Contributor

@dflitner dflitner commented Feb 5, 2020

Workaround for issue 1328. Setting width of seadragon's container so images will display full-width.

GitHub Issue: Islandora/documentation#1328

What does this Pull Request do?

Workaround for Open Seadragon's image viewer being very skinny.

What's new?

.field-formatter-openseadragon-image .field-type-image__item {
width: 100%;
}

Sets the width of the container element for Open Seadragon image viewers to 100% so that the viewer will display at the full page width.

This is very specific and shouldn't affect the display of other image fields.

How should this be tested?

Attach image (jpg/png) media to item, see skinny viewer. Apply PR, clear cache, see viewer stretch the width of the page.

Side effect: Smaller images may stretch out to fit the width of the viewer and gain artifacts.

Interested parties

@Islandora/8-x-committers

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-unlv seth-shaw-unlv merged commit ad2d2d1 into Islandora:8.x-1.x Feb 5, 2020
@dflitner dflitner deleted the 1328-fix branch February 5, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants