update readme #15
Merged
update readme #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I updated the license to link to the one in the repo and it appears to be the right "kind" of license for Drupal module but I can't actually speak to the content of the License file. |
manez
reviewed
Sep 27, 2019
README.md
Outdated
| @@ -1,4 +1,5 @@ | |||
| # OpenSeadragon | |||
| #  | |||
There was a problem hiding this comment.
Image should go before the repo name so they end up on the same lie: #  Repository Name
README.md
Outdated
|
|
||
| Having problems or solved a problem? Check out the Islandora google groups for a solution. | ||
|
|
||
| * [Islandora Group](https://groups.google.com/forum/?hl=en&fromgroups#!forum/islandora) * [Islandora Dev Group](https://groups.google.com/forum/?hl=en&fromgroups#!forum/islandora-dev) |
There was a problem hiding this comment.
should be two bullets instead of one line of text. This may be a problem carried over from the template?
README.md
Outdated
| Having problems or solved a problem? Check out the Islandora google groups for a solution. | ||
|
|
||
| * [Islandora Group](https://groups.google.com/forum/?hl=en&fromgroups#!forum/islandora) * [Islandora Dev Group](https://groups.google.com/forum/?hl=en&fromgroups#!forum/islandora-dev) | ||
|
|
||
| ## Maintainers | ||
|
|
||
| Current maintainers: | ||
|
|
||
| * [Jared Whiklo](https://github.com/whikloj) |
There was a problem hiding this comment.
Should remove the old maintainer. It's all you now, @elizoller 😄
README.md
Outdated
|
|
||
| ## License | ||
|
|
||
| [GPLv2](http://www.gnu.org/licenses/gpl-2.0.txt) | ||
| [GPLv2](https://github.com/Islandora-CLAW/openseadragon/blob/8.x-1.x/LICENSE) |
There was a problem hiding this comment.
This link works, but I think it can be simplified to [GPLv2](/LICENSE] ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (Islandora/documentation#1267)
Tech call minutes
What does this Pull Request do?
Updates Readme to standards
What's new?
An updated readme and logo
How should this be tested?
Give it a read and compare it to the template.
Interested parties
@Islandora-CLAW/committers @manez