Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve arrays without @id #62

Merged
merged 1 commit into from
Jun 24, 2022
Merged

preserve arrays without @id #62

merged 1 commit into from
Jun 24, 2022

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: #61

What does this Pull Request do?

Removes assumption that if the first array has '@id' then they all do. Now, just copy the value or check for deduplication if it has an '@id'.

What's new?

A in-depth description of the changes made by this PR. Technical details and
possible side effects.

  • Changes NormalizerBase::deduplicateArrayOfIds to not just copy if the first one doesn't have '@id' but to also simply copy the array part if there isn't an '@id'.
  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? Clear cache.
  • Could this change impact execution of existing code? Stop generating jsonld errors about missing '@id' keys.

How should this be tested?

Not sure. Never got around to figuring out exactly what combination of metadata generated this error.

Interested parties

@Islandora/committers, esp. @whikloj

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good solution.

I was originally trying to build a test case to cause the error but I couldn't get it there.

@whikloj
Copy link
Member

whikloj commented Jun 24, 2022

@rosiel @kstapelfeldt Could someone with access update the required checks on this repository please.

@seth-shaw-unlv
Copy link
Contributor Author

@whikloj, branch protection rules have been updated. You are cleared to merge.

@whikloj whikloj merged commit 3686e94 into Islandora:2.x Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants