Update PDF.js version #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless I'm misunderstanding, it looks like there are two PRs open on this same issue: #39 ? @DonRichards and @dheles since it's so hard to get 7.x PRs tested and merged these days, maybe you two can coordinate, pick one as canonical, and have the other test it? |
|
Oops, my bad. I hadn't noticed Don's PR when submitting. Though when I tested PDF.js 1.10.100, it didn't fix the issue with the particular PDF that was failing to load for me. @DonRichards I presume that version fixes the issue in the context in which you you were testing. Did you happen to test v2.x as well? |
|
@dheles I submitted it as a safe alternative but I just tested the latest version (this version) and I don't see any issues with it. |
|
24 hours and I'll merge |
|
Thanks, @DonRichards ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://jira.lyrasis.org/browse/ISLANDORA-2530
What does this Pull Request do?
The PDF viewer provided by the pdfjs module has begun failing to load pages. Checking in your browser's debugging console indicates PDF.js is the culprit. Updating the version used in the module fixes the problem.
What's new?
Updates PDF.js to the current version (2.10.377)
How should this be tested?
Additional Notes:
The new version of PDF.js additionally adds some new viewing options, e.g. horizontal scrolling
Interested parties
@Islandora/7-x-1-x-committers