Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#43 Add isset() to prevent PHP warning when no plugins enabled #44

Merged
merged 1 commit into from
Mar 13, 2024
Merged

#43 Add isset() to prevent PHP warning when no plugins enabled #44

merged 1 commit into from
Mar 13, 2024

Conversation

kayakr
Copy link

@kayakr kayakr commented Mar 12, 2024

What does this Pull Request do?

Add isset() to prevent PHP Warning.

How should this be tested?

  1. When no plugins enabled, observe PHP warnings when viewing Mirador block.
  2. Apply PR / patch.
  3. Observe no PHP warning when viewing Mirador block.

Interested parties

@elizoller @alxp

@kayakr kayakr requested a review from alxp March 12, 2024 01:37
@kayakr kayakr self-assigned this Mar 12, 2024
@alxp alxp merged commit 87d5248 into Islandora:2.x Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxp alxp alxp approved these changes

Assignees

@kayakr kayakr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayakr @alxp