Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metadata_map_plugins OAI setting #78

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Update metadata_map_plugins OAI setting #78

merged 1 commit into from
Mar 8, 2023

Conversation

joecorall
Copy link
Member

What does this Pull Request do?

Fixes the OAI-PMH default setting module from failing on new installs

What's new?

Updated the rest_oai_pmh config to its new schema.

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)

Create a new Drupal site with and enable Islandora OAI PMH. It will error

Cannot access offset of type string on string in Drupal\rest_oai_pmh\Plugin\rest\resource\OaiPmh->__construct() (line 116 of /code/web/modules/contrib/rest_oai_pmh/src/Plugin/rest/resource/OaiPmh.php)

Interested parties

@Islandora/committers

@rosiel rosiel merged commit 15b66cd into Islandora:3.x Mar 8, 2023
@joecorall joecorall deleted the patch-1 branch May 29, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosiel rosiel rosiel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joecorall @rosiel