Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update islandora_oaipmh for rest_oai_pmh:alpha-10 #20

Merged
merged 2 commits into from
Jan 21, 2020
Merged

Update islandora_oaipmh for rest_oai_pmh:alpha-10 #20

merged 2 commits into from
Jan 21, 2020

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: Islandora/documentation#1360

What does this Pull Request do?

In the alpha-10 release of rest_oai_pmh the metadata schema selection was changed to using Plugins instead of theme hooks (don't worry, you can still create custom metadata profiles using twig templating). This PR updates the default settings to use the dublin_core_rdf plugin.

What's new?

  • A few Feature-export clean-up bits
  • Added default configuration to use dublin_core_rdf plugin
  • Does this change require documentation to be updated? See Create: oai-pmh doc documentation#1345
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? Clear your cache.
  • Could this change impact execution of existing code? Not for a vanilla repository, but if anyone already customized their rest_oai_pmh (which is unlikely at this point), they should now use the new plugin architecture.

How should this be tested?

  • Update rest_oai_pmh: composer require drupal/rest_oai_pmh (should now be at least "1.0.0-alpha10").
  • Apply the PR
  • Feature import: drush fim -y islandora_oaipmh
  • Clear cache: drush cr
  • Visit the OAI PMH settings (http://localhost:8000/admin/config/services/rest/oai-pmh) and see the 'oai_dc' metadata mapping is configured to use 'OAI Dublin Core (RDF Mapping)'.
  • Bonus: if you have repository item content, make sure you've built the OAI-PMH entries (http://localhost:8000/admin/config/services/rest/oai-pmh/queue) although re-building is not necessary if you've already done so, and make sure it works (http://localhost:8000/oai/request?verb=ListRecords&metadataPrefix=oai_dc).

Interested parties

@Islandora/8-x-committers, @elizoller & @joecorall.

@seth-shaw-unlv
Copy link
Contributor Author

Could I get a reviewer, @Islandora/8-x-committers? Pretty, pretty please?

Roger Rabbit Please

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was running into issues, tested this PR and now they're gone 😎 :

:shipit:

@dannylamb dannylamb merged commit 0584678 into Islandora:8.x-1.x Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants