Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for deprecated Symfony Event class #928

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

seth-shaw-asu
Copy link
Member

@seth-shaw-asu seth-shaw-asu commented Feb 9, 2023

GitHub Issue: #927

What does this Pull Request do?

Updates deprecated Symfony Event class with the new Drupal one and updates the argument order for the dispatch function as specified in https://www.drupal.org/node/3159012.

What's new?

  • Does this change add any new dependencies? No, although it now uses the JWT module's 1.1 release.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? No.

How should this be tested?

Short version

Smoke test. Does anything break?

Longer version

  1. composer require webprofiler
  2. drush en -y webprofiler
  3. drush cr = 💥
  4. Apply PR
  5. drush cr = 👍 (unless you have other modules enabled with the same problem)

Documentation Status

  • Does this change existing behaviour that's currently documented? No.
  • Does this change require new pages or sections of documentation? No.
  • Who does this need to be documented for? No one.

Interested parties

@Islandora/committers

@wgilling wgilling self-requested a review February 15, 2023 18:18
Copy link
Member

@jordandukart jordandukart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described, messages to go out to ActiveMQ and things are generated. Don't see a blow up with webprofiler either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants