No longer double negating conditions #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seth-shaw-unlv
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: Resolves Islandora/documentation#1325
What does this Pull Request do?
Stops doing negation logic in our Condition plugins so they can be negated downstream.
What's new?
Less checks using
isNegated().How should this be tested?
Pull down the PR and set up contexts using these Conditions to do something simple like switch themes:
EntityBundleMediaHasMimetypeNodeHadNamespaceNodeHasParentNodeIsPublishedThe contexts should behave as expected both normally and when negated.
Interested parties
@Islandora/8-x-committers @qadan