Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing PHP 7.2 and 7.3 #737

Merged
merged 2 commits into from
Oct 21, 2019
Merged

Testing PHP 7.2 and 7.3 #737

merged 2 commits into from
Oct 21, 2019

Conversation

dannylamb
Copy link

JIRA Ticket: Islandora/documentation#1267

What does this Pull Request do?

Tests on 7.2 and 7.3, which we should do everywhere. Hence I'm adding this as part of the CLAWdit.

Interested parties

@Islandora/8-x-committers

@dannylamb
Copy link
Author

Hrm... not ingoring the 7.3 fail for some reason....

.travis.yml Outdated

matrix:
fast_finish: true
allowed_failures:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allow_failures:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i bet i copy/pasted that across every repo...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

Copy link
Member

@whikloj whikloj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whikloj whikloj merged commit e1bc6f7 into 8.x-1.x Oct 21, 2019
@whikloj whikloj deleted the issue-1267 branch October 21, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants