forked from alxp/islandora
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
959 configurable width height caching #1029
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndora IIIF manifest generator.
… JP2 dimensions from IIIF server.
…od link with given dimensions.
…r the IIIF Dimensions actions.
adam-vessey
reviewed
Jun 25, 2024
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
This is ready for you to test @aOelschlager |
adam-vessey
reviewed
Jul 10, 2024
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
Co-authored-by: Adam <607975+adam-vessey@users.noreply.github.com>
aOelschlager
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the testing instructions and I was able to populate and view the width and height of both tiff and jp2 files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
Release pull requests, etc.)
What does this Pull Request do?
Resolves #959 by:
What's new?
adding an action for retrieving a TIFF or JP2'ss image dimensions which can be added as a context reaction when the media is uploaded, off-loading the work from the IIIF Manifest style plugin.
Fixes the logic in the IIIF Manifest Views style plugin to let a user choose custom Width and Height fields for Large Images, while still falling back on field_width and field_height if they exist.
Puts the Structured Text Field as well as custom Width and Height fields under an Advanced closed detail section to simplify the IIIF Manifest Style plugin's UI. This update also includes an update hook to handle the new config key.
Updates to the Islandora IIIF README to include instructions for using the new action and removing old terminology.
(i.e. Regeneration activity, etc.)? No
How should this be tested?
On a fresh Islandora Starter Site:
5. Now go to the Original File media again and click Edit. You should see that the Width and Height fields now contain the values as seen in the manifest in step 4.
To test the action:
Documentation Status
Updated the README in islandora_iiif with instructions.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Replaces an outdated PR #983 . Improvements from code review comments from that PR have ben incorporated into this one.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers