Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDST-70: Fix use of batch methods from decorated services. #1027

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

adam-vessey
Copy link

GitHub Issue: Fixes Islandora/documentation#2320

  • Other Relevant Links (Google Groups discussion, related pull requests,
    Release pull requests, etc.)

What does this Pull Request do?

Fix use of batch methods from decorated services.

What's new?

Moved the serialization of the batch processor back to the form class, instead of attempting to serialize the service info into the batch definitions proper.

  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? Highly unlikely.

How should this be tested?

Regression test using the batch child and media upload forms.

Documentation Status

  • Does this change existing behaviour that's currently documented? No.
  • Does this change require new pages or sections of documentation? No.
  • Who does this need to be documented for? Nobody? Devs? Shrug?
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@adam-vessey adam-vessey changed the title Fix use of batch methods from decorated services. DDST-70: Fix use of batch methods from decorated services. Jun 4, 2024
@rosiel rosiel requested a review from alxp June 12, 2024 17:11
Copy link

@alxp alxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested batch child and batch media upload and both work as expected.

@alxp alxp merged commit e36ad17 into 2.x Jun 18, 2024
24 checks passed
@alxp alxp deleted the fix/child-upload-serialization branch June 18, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Decoration of child/media upload batch processor services fails to (un)serialize inner/decorated service
2 participants