Composer replace islandora/islandora. #1022
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2270
Other Relevant Links (Google Groups discussion, related pull requests,
Release pull requests, etc.)
Prefer drupal namespace in Composer. #1020
What does this Pull Request do?
Tells composer that this repo contains the code of islandora/islandora. This matters when we access it through Drupal.org and the drupal/ namespace.
What's new?
Composer.json now includes a
"require"
section, patterned after @adam-vessey 's great suggestion in the above-linked PR.(i.e. Regeneration activity, etc.)? no
How should this be tested?
This allows the project to be used when a dependency depends on islandora/islandora. Due to how Composer pulls this info from repos, direct testing is difficult.
To test, you would need to change the repo name from islandora/islandora to drupal/islandora. But we've decided we're not doing that yet!
However I have tested, and found that this directive allows islandora_hierarchical_access (a module that depends on islandora) to be installed with only drupal/islandora:
Documentation Status
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers