Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer replace islandora/islandora. #1022

Closed
wants to merge 2 commits into from
Closed

Composer replace islandora/islandora. #1022

wants to merge 2 commits into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 28, 2024

GitHub Issue: Islandora/documentation#2270

What does this Pull Request do?

Tells composer that this repo contains the code of islandora/islandora. This matters when we access it through Drupal.org and the drupal/ namespace.

What's new?

Composer.json now includes a "require" section, patterned after @adam-vessey 's great suggestion in the above-linked PR.

  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? yes, ish, but in the desired way.

How should this be tested?

This allows the project to be used when a dependency depends on islandora/islandora. Due to how Composer pulls this info from repos, direct testing is difficult.

To test, you would need to change the repo name from islandora/islandora to drupal/islandora. But we've decided we're not doing that yet!

However I have tested, and found that this directive allows islandora_hierarchical_access (a module that depends on islandora) to be installed with only drupal/islandora:

Rosies-MacBook-Pro:islandora-starter-site [git:pathauto+] rlefaive % composer why islandora/islandora
discoverygarden/islandora_hierarchical_access v1.3.0                                requires islandora/islandora (^2)           
drupal/islandora                              dev-composer-shim-islandora-namespace replaces islandora/islandora (self.version) 

Documentation Status

  • Does this change existing behaviour that's currently documented? no
  • Does this change require new pages or sections of documentation? no
  • Who does this need to be documented for? email coming soon.
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

@rosiel
Copy link
Member Author

rosiel commented May 29, 2024

This branch is breaking packagist, as a project cannot replace itself.

@rosiel rosiel closed this May 29, 2024
@rosiel rosiel deleted the composer-replace branch May 29, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant