Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing-a-pull-request.md #2336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update testing-a-pull-request.md #2336

wants to merge 1 commit into from

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jul 29, 2024

Purpose / why

After @DonRichards 's comments on Slack I went and added to the docs - I didn't see #2335 .

My preference for mine is that Composer is not supposed to be run as root, and nginx is not the only possible owner for the site files.

I also made a separate section for changes to configs, since they're relevant regardless of which method you choose.

And I added warnings at the top of the page about the file permission issue (which is a real issue, I don't want to diminish it)

What changes were made?

Listed three ways to update configs, one copied from @DonRichards

Verification

Are the instructions readable and typo- or error-free?

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://Islandora.github.io/documentation/pr-preview/pr-2336/
on branch gh-pages at 2024-07-29 13:34 UTC

@DonRichards DonRichards self-requested a review August 7, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant