Added doc on testing a pull request. #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Co-authored-by: Jordan Dukart <jordan@discoverygarden.ca>
Co-authored-by: Jordan Dukart <jordan@discoverygarden.ca>
Co-authored-by: Jordan Dukart <jordan@discoverygarden.ca>
Co-authored-by: Jordan Dukart <jordan@discoverygarden.ca>
Co-authored-by: Jordan Dukart <jordan@discoverygarden.ca>
jordandukart
approved these changes
May 24, 2024
rosiel
added a commit
to rosiel/documentation
that referenced
this pull request
May 29, 2024
* Added doc on testing a pull request. * minor grammar tweaks. * formatting. * Rename to testing a pr * Document using prefer-source. (Islandora#2309) * Minor edits to Jordan's PR and remove trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / why
Agreed during the Committers Call that this is a necessary addition to the documentation.
What changes were made?
New page! "Running custom code" (i.e. testing a pull request)
also, a few tweaks to bring the examples in line with what we're suggesting (i.e. drupal/ composer namespace)
Verification
Please read and test the instructions for testing a PR!
Interested Parties
Checklist
Pull-request Reviewer
Pull-request reviewer should ensure the following:
Person Merging
The person merging should ensure the following: