Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated maintaining drupal instructions #2223

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

joshdentremont
Copy link
Contributor

@joshdentremont joshdentremont commented Apr 18, 2023

Purpose / why

Updated the instructions for maintaining Drupal to add note about production, and address some permission issues that can happen when running Composer commands.

What changes were made?

Added a note to explain that updating Drupal should be done on a development site, then those updates can be built into an image for production.

Updated composer instructions to run as nginx user which makes new files owned by nginx.

Added a note about settings.php permission issue which happens when Mac users build a site based on the starter site (Islandora-Devops/isle-dc#306).

Verification

Installing a new site using make starter then running the new Composer update command should allow you to update your modules and everything should be owned by nginx. Using the old command would have new files owned by root.

If you are on Mac you will get the error that settings.php can't be written to. Updating it's permissions so nginx can write to it should allow the composer update to succeed.

Interested Parties

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@aOelschlager aOelschlager merged commit b3d949a into Islandora:main Apr 19, 2023
@ysuarez
Copy link
Contributor

ysuarez commented Apr 19, 2023

At today's tech call we feel this could be merged as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants