Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'defaults' to 'starter site' #2176

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Sep 27, 2022

Purpose / why

Move references from "Islandora Defaults" to "Islandora Starter Site"

What changes were made?

  • "Islandora Defaults" becomes "the Islandora Starter Site" in most cases.
  • removed release instructions for Defaults; Starter Site release process is still to be decided.
  • YET TO DO [DRAFT] - update manual install instructions

Verification

Read it through, is it grammatical and free of spelling errors?
For install instructions: do they work?

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel rosiel changed the title Change 'defaults' to 'starter site' except manual install. Change 'defaults' to 'starter site' Sep 27, 2022
@rosiel
Copy link
Member Author

rosiel commented Sep 28, 2022

Question for the Tech team: What is the purpose of installing Drupal at /opt/drupal? Every other method we have puts it in /var/www/drupal or /var/www/html/drupal. Should we keep the manual instructions doing something so different? Also, comments on the work thus far are welcome. I am not done with the Manual Install instructions yet.

@rosiel
Copy link
Member Author

rosiel commented Sep 28, 2022

Nevermind the above comment. I'm going to mark the "manual install" pages with a warning that they are in need of review. Perfecting them is out of scope of this PR.

@rosiel rosiel marked this pull request as ready for review October 13, 2022 18:16
docs/user-documentation/content_types.md Outdated Show resolved Hide resolved
docs/user-documentation/content_models.md Show resolved Hide resolved
docs/user-documentation/content_models.md Outdated Show resolved Hide resolved
@@ -146,9 +146,8 @@ Sites concerned with access control wish to "lock down" their Fedora to only be

## Access control in the Triplestore

In Islandora Defaults, there is no access control on the Blazegraph triplestore. Islandora defaults is configured so that all RDF triples sent to Fedora are also populated into the triplestore. If using the Ansible Playbook, it is available at http://localhost:8080/bigdata/. Like the solr index, it is open to the world by default.

In a site created with ISLE or the Islandora Playbook, there is no access control on the Blazegraph triplestore. The Islandora Starter Site configuration is such that all RDF triples sent to Fedora are also populated into the triplestore. Like the solr index, it is open to the world by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default on ISLE the Blazegraph GUI is not accessible. The port would need to be exposed in the environment file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're totally right. The ISLE docs say you can explore them at traefik.me URLs, but at least since 10 months ago they're not exposed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the new verbiage work for you? My concern is that any site created before Dec 2021 did not have this available. I am also not clear on whether it's possible to "update isle-dc" to make these options available on an existing site, or if doing that would involve destructive changes that would not be advisable on existing sites.

Anyone with access to Blazegraph can access all the repository information within Blazegraph. If this is not desired, you should restrict access to the Blazegraph endpoint and GUI. By default, the Islandora Playbook exposes Blazegraph at http://localhost:8080/bigdata/. ISLE-DC on the other hand can expose or not expose individual services, including Blazegraph. Since December 2021 this has been available as an option in the .env file and since that time, Blazegraph (and some other services) are not exposed by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I wasn't being to picky with the phrasing and your concern is absolutely valid too. I do like how you reworded it now. I only brought it up because the question of exposing those services has come up a few times in slack this year. It shouldn't be destructive to existing sites data to make the change but it may make the site temporarily unavailable in order to pull in the changes.

docs/user-documentation/access-control.md Outdated Show resolved Hide resolved
Copy link
Contributor

@aOelschlager aOelschlager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Great work Rosie!

@rosiel
Copy link
Member Author

rosiel commented Oct 14, 2022

Thanks @aOelschlager! Anyone who can see the big green button is free to squash-and-merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants