Improve Certificate Section #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misilot
force-pushed
the
acme-improve-docs-1
branch
from
5fb3fa3
to
cb4acbd
Compare
|
I may be able to review this PR once the PRs this depends on are committed. I can try building an AWS EC2 based instance with an outside IP address to be able to test out the "Let's Encrypt" instructions. Though at first glance they look tally fine to me. |
Creates distinct sections for your own certificate, Let's Encrypt, and the traefik.me options. Cleaned up the table a little that explains the two cert files. I changed from the `cert.pem` to __cert.pem__ so it the line wraps correctly. Cleaned up the troubleshooting section a little, and added a note about redownloading the traefik.me certificate
misilot
force-pushed
the
acme-improve-docs-1
branch
from
cb4acbd
to
7bfe140
Compare
|
@ysuarez, sorry I updated this PR description by accident. This PR has no outstanding dependencies. |
alxp
approved these changes
May 11, 2022
|
Thanks @alxp! |
misilot
added a commit
to misilot/documentation
that referenced
this pull request
May 11, 2022
Creates distinct sections for your own certificate, Let's Encrypt, and the traefik.me options. Cleaned up the table a little that explains the two cert files. I changed from the `cert.pem` to __cert.pem__ so it the line wraps correctly. Cleaned up the troubleshooting section a little, and added a note about redownloading the traefik.me certificate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / why
Updated Docs regarding Certificates
What changes were made?
Creates distinct sections for your own certificate, Let's Encrypt, and the traefik.me options.
Cleaned up the table a little that explains the two cert files. I changed from the
cert.pemto cert.pem so it the line wraps correctly.Cleaned up the troubleshooting section a little, and added a note about redownloading the traefik.me certificate
Verification
Interested Parties
@Islandora/documentation
Checklist