Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different theme for PRs #1845

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Use different theme for PRs #1845

merged 1 commit into from
Jun 2, 2021

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Jun 2, 2021

Purpose / why

Travis is breaking on PR's, as it can't use the github token to access the mkdocs-material-insiders theme. this is expected Travis behaviour for security reasons.

https://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions

Switch to using normal Material for PRs.

Replace this text - Name some folks who may be interested, if documentation related mention @Islandora/documentation, or, if unsure, @Islandora/8-x-committers


Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel rosiel mentioned this pull request Jun 2, 2021
8 tasks
@mjordan mjordan merged commit 2fe8c13 into Islandora:main Jun 2, 2021
@rosiel rosiel deleted the travis branch December 10, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants