Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "make command not found" failure fix #1816

Closed
wants to merge 1 commit into from

Conversation

archivalGrysbok
Copy link

Purpose / why

I skimmed the directions and got the error "make command not found". Others might, too.

What changes were made?

Added description of error and the fix.

Verification

I spell checked?

Interested Parties

@Islandora/documentation

Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

I skimmed the directions and ran into this issue. Others might, too.
@manez
Copy link
Member

manez commented May 19, 2021

Thank you for this, @archivalGrysbok ! Alas, I'm afraid we have one small hoop to clear for first-time contributors:

Before you set out to contribute code you will need to have completed a Contributor License Agreement or be covered by a Corporate Contributor Licencse Agreement. The signed copy of the license agreement should be sent to mailto:community@islandora.ca

This license is for your protection as a contributor as well as the protection of the Foundation and its users; it does not change your rights to use your own contributions for any other purpose.

@DonRichards
Copy link
Member

@manez This submission isn't actual code (just documentation). Is it possible this could be an exception?

@manez
Copy link
Member

manez commented Nov 19, 2021

@DonRichards per policy and practice at the IF, I'm afraid not. All contributions are treated equal in the eyes of the CLA. The Documentation Interest Group has this one in their sights and a volunteer to redo it, but it hasn't happened yet.

ysuarez added a commit to ysuarez/documentation that referenced this pull request Dec 5, 2021
@ysuarez
Copy link
Contributor

ysuarez commented Dec 5, 2021

I just created PR #1995 to essentially recreate this PR (#1816) I am commenting on. Since we never got a CLA from the contributor after repeated attempts to contact them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants