Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections #1769

Merged
merged 7 commits into from
Mar 4, 2021
Merged

Collections #1769

merged 7 commits into from
Mar 4, 2021

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Mar 1, 2021

Purpose / why

Let's split out "conceptual" stuff from "how-to" stuff! I started with Collections, and made a page under "Concepts" that talks about what stuff is and what drupal mechanisms we use. Then, I put the remaining (good!) tutorial info under tutorials. There is much more to do, i just wanted to start somewhere and do a small PR at first rather than an entire overhaul.

What changes were made?

new collections concept page.

Verification

Is the info valid?

Interested Parties

@Islandora/8-x-committers @Islandora/documentation

Checklist

Pull-request reviewer should ensure the following

  • Does this PR link to related issues?
  • Does the proposed documentation align with the Islandora Documentation Style Guide?
  • Are the changes accurate, useful, free of typos, etc?
  • Does this PR update the last updated on date on the documentation page?

Person merging should ensure the following

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@rosiel rosiel requested a review from eldonquijote March 2, 2021 14:17
Copy link
Contributor

@eldonquijote eldonquijote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great work separating conceptual/procedural information! I can build the documentation locally. Please ignore my comments if I completely misunderstood how things work.

docs/concepts/collection.md Outdated Show resolved Hide resolved
docs/concepts/collection.md Outdated Show resolved Hide resolved
@seth-shaw-unlv seth-shaw-unlv merged commit 252f013 into Islandora:main Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants